Repository navigation
Mint directory_user, directory_group, group_membership, license_assignment (0x0B06–0x0B09); flow body 0x1718 - #370
Merged
Merged
Conversation
…hip, license_assignment (0x0B06-0x0B09) Four IAM-domain concepts above email: a directory user and group as observed (AD / Entra), one user-to-group membership edge, and one observed license SKU on one user. They are what directory reads bind to and what RBAC grants and field masks on directory data key on. Each gets a promoted Class and an ogar-class-view registry row; the Auth domain count moves from 5 to 9. ogar-flow-m365 binds its directory operations to them (ConceptBinding::Minted) and declares its flow body concept 0x1718, a palette slot above blockly-rs 0x1717 kept crate-local like every palette, with vocab::plug_into for VocabularyRegistry. The lance-graph-contract ogar_codebook mirror rows land in the paired lance-graph PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMM44PgMCtYoqx6XYnh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds four concepts to the IAM domain of
ogar-vocab, placed afteremail(0x0B05):0x0B06directory_user0x0B07directory_group0x0B08group_membership0x0B09license_assignmentThese are the concepts that directory reads bind to.
OgarRbacgrants and field masks on directory data key on them. Each concept gets:CODEBOOKrow,class_idsconst and an entry inclass_ids::ALL,Classbuilder,ogar-class-viewregistry.The Auth-domain count goes from 5 to 9.
ogar-flow-m365(PR-FLOW-01, #368) now binds its directory operations to these concepts withConceptBinding::Minted:query_user,update_user,remove_user→directory_userread_membership,add_group_member→group_membershipread_license_evidence,assign_license→license_assignmentIt also declares the flow body's concept id,
0x1718, and addsvocab::plug_intoso the vocabulary can be registered in aVocabularyRegistry.0x1718is a palette slot above blockly-rs's0x1717, so it stays in the crate. The existing guardno_0x17xx_row_reached_the_globally_mirrored_codebookkeeps it out ofclass_ids::ALL.The
ogar-dir-coredependency is dropped (it was only used for the oldDirSchemabinding).ogar-vocabmoves from a dev-dependency to a normal dependency; it has no dependencies of its own.Paired PR: merge this one first
The zero-dep mirror rows are in AdaWorldAPI/lance-graph (
lance-graph-contract::ogar_codebook, PR linked below). That repo'slance-graph-ogar::assert_codebook_paritychecks both directions against OGARmain. Whichever PR merges first, lance-graph's parity step stays red until the other one lands. The lance-graph PR's own check needs this one onmain, so the order is: this PR, then the mirror.Tests
ogar-vocab: 175 passed.ogar-class-view: 14 passed.ogar-flow-m365: 31 passed. There are two new tests: every directory operation binds to its minted concept, and the vocabulary plugs into a registry under0x1718. Changing one binding makes the first test fail.ogar-osm,ogar-adapter-csharp,ogar-adapter-pythonandogar-rbacpass.-D warningsandfmt --all --checkare clean.cargo test --workspace --no-fail-fastran locally. The only failures:ogar-r2il::the_table_matches_r2il_s_own_enum(84 vs 82 opcodes). That one fails onmainwithout this change: upstream r2sleigh added two opcodes.Generated by Claude Code